Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist realname of always-on clients #1065

Closed
slingamn opened this issue May 26, 2020 · 4 comments · Fixed by #1180
Closed

persist realname of always-on clients #1065

slingamn opened this issue May 26, 2020 · 4 comments · Fixed by #1180
Assignees
Milestone

Comments

@slingamn
Copy link
Member

They can change it with /quote setname if necessary.

@slingamn slingamn added this to the v2.2 milestone May 26, 2020
@slingamn slingamn added the release blocker Blocks release label Jun 26, 2020
@clukawski
Copy link
Contributor

I'll take a look at this then

@slingamn
Copy link
Member Author

Implementation note: I think this can just be a new field of AccountSettings. (So far they're all enums and bools, but there's no architectural reason we couldn't have a freeform string in there.)

@slingamn
Copy link
Member Author

slingamn commented Jul 6, 2020

Ignore the above note --- settings are updated via CAS (to avoid updates to one field clobbering another). This isn't a good fit for realname updates.

@clukawski
Copy link
Contributor

clukawski commented Jul 6, 2020

general notes:

  • create AccountManager.saveRealname() AccountManager.loadRealname() for persistence
  • check if user set as always-on during registration (opt-out or mandatory), after call to AccountManager.Login() via Client.alwaysOn, call client.markDirty() with new dirty bit for realname
  • Client.performWrite() will persist client realname via AccountManager.saveRealname()
  • AccountManager.createAlwaysOnClients() load with AccountManager.loadRealname() and sets client.realname via call to Server.AddAlwaysOnClient()
  • Client.SetRealname() should call Client.markDirty() with the aforementioned realname dirty bit if always on is set for client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants