Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new default: no public plaintext listener #801

Merged
merged 1 commit into from Feb 23, 2020

Conversation

slingamn
Copy link
Member

@DanielOaks I won't merge this without your approval.

I feel like public plaintext is a bad default for 2020, and goes against the ideas in ircv3/ircv3-ideas#45. But if you think this is an unfriendly default, or insufficiently batteries-included, I get it.

@csmith I'm not 100% clear on how this would interact with the Docker configs; would 6667 still be exposed despite this change, because of EXPOSE and -p?

@slingamn slingamn added this to the v2.0 milestone Feb 21, 2020
@csmith
Copy link
Contributor

csmith commented Feb 21, 2020

Yeah, if you're running in docker per the README in dist/docker then it will still expose 6667.

But docker's not doing anything clever - if the ora binary isn't listening on 6667 then connections will fail in basically the same way they'd fail if it was running on bare-metal.

(If this lands we should update the docker bits though, as it'll be weird and confusing to expose a port we're not listening on!)

@DanielOaks
Copy link
Member

Yep, let's do this

@slingamn slingamn merged commit 01144a8 into ergochat:master Feb 23, 2020
@slingamn slingamn deleted the plaintext_listeners branch March 9, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants