Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-stop failure when kubeconfig is configured as a path-config-file #19

Open
poblin-orange opened this issue Dec 10, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Projects

Comments

@poblin-orange
Copy link
Member

poblin-orange commented Dec 10, 2020

When helm-kubectl bosh release is used with another bosh release, creating the kubeconfig as a path-config-file (typically k3s bosh release), the pre-stop script breaks and locks the deployment when the kubeconfig.yml is not found.

https://github.com/orange-cloudfoundry/helm-kubectl-boshrelease/blob/master/jobs/action/spec#L36

This can happen at first deployment time (order of pre-start/pre-stop is not predictible in bosh)
=> the pre-stop should not depend on kubeconfig.yml file existence to check the target bosh deployment state.

https://github.com/orange-cloudfoundry/helm-kubectl-boshrelease/blob/master/jobs/action/templates/bin/pre-stop.erb#L2

    server/04cacacf-fbe4-46bf-bb44-2c359d512daf:/var/vcap/jobs/action/bin# ./pre-stop 
    found correct rubygems version 3.1.2
    cp: cannot stat '/var/vcap/store/k3s-server/kubeconfig.yml': No such file or directory
@poblin-orange poblin-orange added the bug Something isn't working label Dec 10, 2020
@poblin-orange poblin-orange added this to Needs triage in backlog via automation Dec 10, 2020
@poblin-orange poblin-orange changed the title pre-stop failure when kubeconfig is configured as a local file pre-stop failure when kubeconfig is configured as a path-config-file Dec 10, 2020
@poblin-orange poblin-orange moved this from Needs triage to High priority in backlog Dec 10, 2020
@obeyler obeyler moved this from High priority to Low priority in backlog Mar 30, 2021
@poblin-orange poblin-orange moved this from Low priority to High priority in backlog Jun 12, 2023
@poblin-orange
Copy link
Member Author

still issues with pre-stop. Should disable this feature (not usefull in a general way, dangerous with multi master architecture)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
backlog
  
High priority
Development

No branches or pull requests

2 participants