Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow an option to allow file store skip copying existed file #777

Open
qweeah opened this issue Jun 18, 2024 · 2 comments
Open

allow an option to allow file store skip copying existed file #777

qweeah opened this issue Jun 18, 2024 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@qweeah
Copy link
Contributor

qweeah commented Jun 18, 2024

Suppose I am using oras-go to copy an artifact into a file store. The artifact contains several files and the copy process aborted half-way after completed copying the first file.

In current version (v2.5.0) If I retry copying the artifact, the first file will still be copied again. Need an option to skip the copying if the target file's name and digest both matches.

@shizhMSFT shizhMSFT added enhancement New feature or request question Further information is requested labels Jun 21, 2024
@shizhMSFT
Copy link
Contributor

It looks like we need to add the file to the file store on executing Exists(). However, it does not make sense as the Exists() should not add the file to the file store even if the file sits on the disk.

@shizhMSFT
Copy link
Contributor

If we add the files to the file store in advance, despite the performance issue, the improvement should be done in the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants