Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce branch policies on the repository #81

Open
7 tasks
toddysm opened this issue Mar 8, 2023 · 3 comments
Open
7 tasks

Enforce branch policies on the repository #81

toddysm opened this issue Mar 8, 2023 · 3 comments

Comments

@toddysm
Copy link

toddysm commented Mar 8, 2023

To improve the security of the ORAS project we need to enforce the branch policies for this repository. I propose that we enforce the policies as follows:

  • Use the following rules for main and release/* branches:
    • Require PR before merging
      • Require 3 approvals
      • Dismiss stale PR approvals when new commits are pushed
      • Require review from Code Owners
      • Require status checks to pass before merging
      • Require conversation resolution before merging
      • Require signed commits
      • Do not allow bypass the above settings

Please add your comments and proposals for additional changes to this issue.

@vsoch
Copy link
Contributor

vsoch commented Mar 8, 2023

This would only work with more contributors. In the past when I’ve asked for PR reviews in slack it would take a month or more, often with a manager doing it. I’m good for branch policies but they need to be reasonably feasible.

@vsoch
Copy link
Contributor

vsoch commented Mar 8, 2023

And how will that improve security? Do you think I’ve been merging code that has introduced security issues? 🤔

@toddysm
Copy link
Author

toddysm commented Mar 8, 2023

This is a fair point @vsoch. Apologies for the copy and paste from the other repos. I would be happy to help with PR reviews and also fixes. And you are right, we need more contributors for the Python libraries.

To answer your question about how this increases security, it is an additional check so unwanted changes don't sneak in either by mistake or because of a compromised account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants