Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --platform in oras push and oras attach #1066

Open
1 task
qweeah opened this issue Aug 18, 2023 · 3 comments
Open
1 task

support --platform in oras push and oras attach #1066

qweeah opened this issue Aug 18, 2023 · 3 comments
Labels
enhancement New feature or request spec required Issues that require specifications
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Aug 18, 2023

What is the version of your ORAS CLI

oras v1.1.0-rc.1

What would you like to be added?

Add a new flag --platform to allow baking platform information into config data like

oras push localhost:5000/oras:v1.0.1 --artifact-type "application/vnd.example+type" --platform linux/amd64 oras--1.0.1.arm64_monterey.bottle.tar.gz
oras attach localhost:5000/oras:v1.0.1 --artifact-type "application/vnd.sbom" --platform linux/amd64 oras--1.0.1.arm64_monterey.bottle.tar.gz

The specified platform information will be stored in the config blob like https://oras.land/docs/concepts/artifact#artifacts-with-config

Why is this needed for ORAS?

User can easily build artifact with platform information without composing config blob on their own.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@amands98
Copy link
Contributor

Should I include support for a platform flag ? // @qweeah

@qweeah
Copy link
Contributor Author

qweeah commented Jan 19, 2024

@amands98 Thanks for volunteering! Please make sure the baked config is following https://github.com/opencontainers/image-spec/blob/main/config.md#properties

@yizha1 yizha1 modified the milestones: future, v1.3.0 Mar 4, 2024
@shizhMSFT
Copy link
Contributor

shizhMSFT commented Mar 14, 2024

What's the media type of the config? Is it artifact-type or the standard config type? How is it supported by multiple cloud providers?

@FeynmanZhou FeynmanZhou added the spec required Issues that require specifications label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spec required Issues that require specifications
Projects
None yet
Development

No branches or pull requests

5 participants