-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oras 1.1.0 breaks AWS ECR uploads #1133
Comments
I'll take a look at this today |
Thanks |
Recreated the problem, but I'm not sure the cause yet. |
@Haitham-Shalaby Can you help clarify what commands are you using? |
Confirmed that it did work with 1.0.1 |
The biggest difference I see is artifactType for 1.0 it was |
Can you use ORAS 1.1.0 sets |
With 1.0
|
Pretty print
|
That doesn't seem very useful, but when pushing to oci-layout, the diff:
|
It has nothing to do with the I guess you are using |
This client defaults to a v1.1 specification, which is not yet released. So to push to ECR (and most other registries), you need to use the
|
Thanks @jlbutler for pointing this out. If you are using $ oras push localhost:6000/spec:v1.0 --config config.json:application/vnd.oci.image.config.v1+json ...
...
Pushed [registry] localhost:6000/spec:v1.0
Digest: sha256:ac75a0db8e295a9205b702ca67cbe61a141b4b3df4d83a900d7daea8f82a30ac
$ oras manifest fetch localhost:6000/spec:v1.0 | jq
{
"schemaVersion": 2,
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"config": {
"mediaType": "application/vnd.oci.image.config.v1+json",
"digest": "sha256:9c7a54a9a43cca047013b82af109fe963fde787f63f9e016fdc3384500c2823d",
"size": 1470
},
...
} |
Should probably leave this open for reference |
Thanks all much appreciated inputs |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Keep this open longer |
Can this default be changed to v1.0? I would consider it a bug to have defaults that are incompatible with the majority of implementations. |
Changing the default value to v1.0 would make ORAS by default generate artifacts not compliant to guidance in OCI image specification. |
Well to be fair, that guidance is from a release candidate spec. The only GA version of either Image or Distribution spec is 1.0. I think it's the intent of this project to lean into the features specified in the 1.1 spec, and move forward with those features as the default. So I think setting the standard for the default to be 1.1 behavior (and maybe always defaulting to latest in future) does make sense. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
I removed the stale label to leave this open a bit longer. Close it in 30 days. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
What happened in your environment?
Oras 1.1.0 breaks AWS ECR uploads with the following error, so revert
back to previous version.
Error: PUT "https://.../manifests/1.21.0-35":
response status code 405: unsupported:
Invalid parameter at 'ImageManifest' failed to satisfy constraint:
'Invalid JSON syntax'
What did you expect to happen?
No response
How can we reproduce it?
AWS deployment
What is the version of your ORAS CLI?
1.1.0
What is your OS environment?
SLES
Are you willing to submit PRs to fix it?
The text was updated successfully, but these errors were encountered: