Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align the behavior of recursive copying #826

Closed
qweeah opened this issue Feb 20, 2023 · 1 comment
Closed

align the behavior of recursive copying #826

qweeah opened this issue Feb 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Feb 20, 2023

The behavior of recursive copying flag --rescursive/-r should be the same no matter the source is an OCI image layout folder or OCI registry.

Expected Behavior

Suppose we have below content:

graph TD
Z>v1] -..-> ML1
ML1 --linux/amd64--> M1
ML1 --linux/arm64--> M2
ML1 --linux/s390x--> M3

A1 --subject-->ML1
A2 --subject--> M1
Loading

Where ML1 is an index (manifest list) with images in multiple architectures. M1, M2 and M3 represents the manifest of images in each arch. A1 and A2 are the artifact manifests with subject pointing to ML1 and M1 respectively.

  • oras cp -r [--from-oci-layout] $FROM:v1 $TO:v2: copy ML1, A1, M1, M2 and M3 to $TO and tag ML1 as v2.
  • oras cp -r [--from-oci-layout] $FROM:v1 $TO: copy ML1, A1, M1, M2 and M3 to $TO without tagging.
  • oras cp -r [--from-oci-layout] $FROM:v1 --platform linux/amd64 $TO:v2: copy M1 and A2 to $TO and tag M1 as v2.
  • oras cp -r [--from-oci-layout] $FROM:v1 --platform linux/amd64 $TO: copy M1 and A2 to $TO without tagging.
  • oras cp -r [--from-oci-layout] $FROM@$M1_DIGEST $TO:v2: copy M1 and A2 to $TO and tag M1 as v2
  • oras cp -r [--from-oci-layout] $FROM@$M1_DIGEST $TO: copy M1 and A2 to $TO without tagging.
@qweeah qweeah added the enhancement New feature or request label Feb 20, 2023
@qweeah qweeah self-assigned this Feb 20, 2023
@qweeah
Copy link
Contributor Author

qweeah commented Feb 26, 2023

Closing since #818 is merged.

@qweeah qweeah closed this as completed Feb 26, 2023
@qweeah qweeah added this to the v1.0.0-rc.2 milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant