Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change client id naming scheme #1136

Open
ebruchez opened this issue Jul 22, 2013 · 6 comments
Open

Change client id naming scheme #1136

ebruchez opened this issue Jul 22, 2013 · 6 comments

Comments

@ebruchez
Copy link
Collaborator

Currently:

  • ids have a prefixed defined by the "container" they are within
  • this means that form author controls can have ids which have prefixes

What we would like to have:

  • ids in top-level scope do not have prefix
  • ids have a prefixed that identifies their scope

This would also facilitate testing with tools like Selenium.

@evdwaard
Copy link

Our preference would also be to not have any $ in the id's (to help jquery work) and to not have any numbers that change when you add a field in the middle of the form. This would help keeping selenium tests working, even if the form changes.

@ebruchez
Copy link
Collaborator Author

Ernout, in 4.3, we have removed the dollar and chosen another special unicode character () which doesn't bother jQuery. And yes, if we do things well, the ids of the controls produced by Form Builder should be stable.

@avernet
Copy link
Collaborator

avernet commented Jun 30, 2014

+1 from customer

@ebruchez ebruchez changed the title Change client id scheme Change client id naming scheme Apr 8, 2015
@avernet
Copy link
Collaborator

avernet commented Apr 9, 2015

+1 from community

@ebruchez
Copy link
Collaborator Author

+1 from community

@ebruchez
Copy link
Collaborator Author

ebruchez commented May 4, 2017

+1 from customer, for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants