Upload sometimes doesn't immediately show file metadata after completion

[ebruchez]

I finally reproduced this locally using throttling:

• form with 2 file attachment controls
• attach file to first one
• before upload has completed (throttling), attach second file
• click on the page outside controls
• wait for uploads to terminate

But I don't always reproduce it.

+1 from customer

[ebruchez]

So far I still don't reproduce it consistently. But I did reproduce it once, and in executeNextRequest() the nested condition probably evaluated to false. Now we need to figure out why.

[ebruchez]

I reproduce this better when throttling at 64 kbps.

The scenario is that the last xxforms-upload-progress event is in progress just at the time the upload response completes. So the executeNextRequest() for xxforms-server-events finds Globals.requestInProgress == true, which is expected.

However, once xxforms-upload-progress completes, it should check the queue again, but it doesn't.

The reason is that we set Globals.requestInProgress = false as a side-effect of running Support.fetchText, but our Future's onComplete which actually handles the Ajax response runs before that side-effect. So it sees Globals.requestInProgress == true still.

The order of onComplete is not guaranteed. We could use andThen instead.

[ebruchez]

To reproduce, the key is to have a very slow connection to maximize the chances that the xxforms-upload-progress will overlap the end of the upload. A single upload control is enough to reproduce.