Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on persistent keystore #29

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@aphelionz
Copy link
Contributor

aphelionz commented May 14, 2019

This PR:

  • Implements the orbit-db-storage-adapter at the test level for creating keystores
  • Removes the creation of a default keystore, but it does use the passed-in keystore as the signingKeystore automatically.

Requires orbitdb/orbit-db-keystore#34

@aphelionz aphelionz mentioned this pull request May 31, 2019
10 of 10 tasks complete
@RichardLitt

This comment has been minimized.

Copy link
Member

RichardLitt commented Jun 27, 2019

Should we add a WIP label to PRs, in general, actually...

src/identities.js Show resolved Hide resolved
@aphelionz aphelionz force-pushed the fix/persistent-store branch 2 times, most recently from d9629a5 to f0887d5 Jul 15, 2019
@aphelionz aphelionz force-pushed the fix/persistent-store branch from f0887d5 to 10c54af Jul 30, 2019
@aphelionz aphelionz force-pushed the fix/persistent-store branch from 2c5cd02 to 226a6a6 Jul 30, 2019
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Jul 31, 2019

@aphelionz lgtm 👍

package.json and src update

keystore path fix

update io deps

fix: removing keystore.open

Forcing keystore options

test: updates

test: fix

chore: package-lock

Updated dependencies

fix: creating default signingKeystore

chore: dependencies

Add localMaintainers field

These people should have access rights to publish on npm. See https://github.com/orbitdb/welcome/blob/master/npm-policy.md.

fix: access keystore directly

fix: restoring _store

update build

v0.1.1

add .npmignore

update build

v1.1.2

v1.1.3

v0.1.4

v0.1.5

fix linting

merging in master

Final build stuff

package lock

Adding default keystore if none exists

Fixing package.json

Changing to keyspath
@aphelionz aphelionz force-pushed the fix/persistent-store branch from 226a6a6 to 75ebf60 Jul 31, 2019
@aphelionz aphelionz merged commit d7a98d1 into master Jul 31, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.