Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing keystore paths #45

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@aphelionz
Copy link
Contributor

aphelionz commented Sep 1, 2019

This PR restores the functionality to pass identityKeysPath and signingKeysPath options to createIdentity

Linting
@aphelionz aphelionz force-pushed the fix/keystore-paths branch from 525a89c to 057f621 Sep 1, 2019
@aphelionz aphelionz mentioned this pull request Sep 1, 2019
@haadcode

This comment has been minimized.

Copy link
Member

haadcode commented Sep 2, 2019

LGTM but would love @shamb0t to review and give their ok before merging.

@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Sep 2, 2019

LGTM 👍

@shamb0t shamb0t merged commit b33894e into master Sep 2, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.