This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
Persistent leveldb connection #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Is this a WIP? |
aphelionz
force-pushed
the
fix/persistent-leveldb-connection
branch
from
1f05c85
to
2c04686
Compare
|
@shamb0t This is squashed and ready for review |
aphelionz
force-pushed
the
fix/persistent-leveldb-connection
branch
from
2c04686
to
74f4ea8
Compare
shamb0t
reviewed
Jul 16, 2019
shamb0t
reviewed
Jul 16, 2019
shamb0t
reviewed
Jul 16, 2019
|
Looking good @aphelionz! I'm getting an error when I try to run tests though |
aphelionz
force-pushed
the
fix/persistent-leveldb-connection
branch
from
74f4ea8
to
e99a16a
Compare
shamb0t
reviewed
Jul 25, 2019
|
Looks good @aphelionz ! Only issue is running the tests modifies the files in the fixtures directory which git detects. A cleaner solution would be to copy the fixtures over to a temporary directory and work from there as done in #33, what do you think? |
aphelionz
force-pushed
the
fix/persistent-leveldb-connection
branch
4 times, most recently
from
1cec4b7
to
9beae82
Compare
fix: search for key in try/catch fix: Moving leveldb one abstraction layer up test: Initial test harness and utils an even more persistent store simplifying keystore fix: open/close noops Updating dependencies to latest chore: dependencies v0.2.1 implementing async close function Upate level update build Update level package-lock fix: verifier data to buffer fix: search for key in try/catch v0.2.1 Upate level update build Update level package lock Robust tests for orbit-db-keystore copy fixtures to temp directory fix webpack dist files Circle CI CircleCI updates fix: verifier data to buffer fix: search for key in try/catch Upate level update build Update level v0.2.2 Removing linting Fixing test:node in preparation for test:browser resolving closed store tests test runs test:node and test:browser browser tests circleci updates YAML fix fixing conf directive in YAML mocha-headless-chrome Adding default keystore Fixing browser tests and fixtures dir Production mode browser Final build Linting fix: verifier data to buffer fix: search for key in try/catch update build Update level make rebuild Re-enabling linting Restoring format
aphelionz
force-pushed
the
fix/persistent-leveldb-connection
branch
from
9beae82
to
e2fa543
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
makecapabilities to the projectindex-*.jsfiles for node and browser and simply exports theKeystoreconstructorKeystore.openandKeystore.closeto unneccesary noops.