Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent leveldb connection #30

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@aphelionz
Copy link
Contributor

aphelionz commented May 14, 2019

This PR:

  • Adds make capabilities to the project
  • Adds rudimentary tests
  • Obviates the need for separate index-*.js files for node and browser and simply exports the Keystore constructor
  • Reduces Keystore.open and Keystore.close to unneccesary noops.
@aphelionz aphelionz mentioned this pull request May 31, 2019
10 of 10 tasks complete
@RichardLitt

This comment has been minimized.

Copy link
Member

RichardLitt commented Jun 24, 2019

Is this a WIP?

@aphelionz aphelionz force-pushed the fix/persistent-leveldb-connection branch from 1f05c85 to 2c04686 Jul 15, 2019
@aphelionz

This comment has been minimized.

Copy link
Contributor Author

aphelionz commented Jul 15, 2019

@shamb0t This is squashed and ready for review

@aphelionz aphelionz force-pushed the fix/persistent-leveldb-connection branch from 2c04686 to 74f4ea8 Jul 15, 2019
package.json Outdated Show resolved Hide resolved
test/keystore.spec.js Outdated Show resolved Hide resolved
test/keystore.spec.js Outdated Show resolved Hide resolved
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Jul 16, 2019

Looking good @aphelionz! I'm getting an error when I try to run tests though

> TEST=all mocha
TypeError: Storage is not a constructor

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! orbit-db-keystore@0.2.1 test: `TEST=all mocha`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the orbit-db-keystore@0.2.1 test script.
make: *** [Makefile:7: test] Error 1```

@aphelionz aphelionz force-pushed the fix/persistent-leveldb-connection branch from 74f4ea8 to e99a16a Jul 17, 2019
src/keystore.js Outdated Show resolved Hide resolved
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Jul 25, 2019

Looks good @aphelionz ! Only issue is running the tests modifies the files in the fixtures directory which git detects. A cleaner solution would be to copy the fixtures over to a temporary directory and work from there as done in #33, what do you think?

@aphelionz aphelionz force-pushed the fix/persistent-leveldb-connection branch 4 times, most recently from 1cec4b7 to 9beae82 Jul 26, 2019
fix: search for key in try/catch

fix: Moving leveldb one abstraction layer up

test: Initial test harness and utils

an even more persistent store

simplifying keystore

fix: open/close noops

Updating dependencies to latest

chore: dependencies

v0.2.1

implementing async close function

Upate level

update build

Update level

package-lock

fix: verifier data to buffer

fix: search for key in try/catch

v0.2.1

Upate level

update build

Update level

package lock

Robust tests for orbit-db-keystore

copy fixtures to temp directory
fix webpack

dist files

Circle CI

CircleCI updates

fix: verifier data to buffer

fix: search for key in try/catch

Upate level

update build

Update level

v0.2.2

Removing linting

Fixing test:node in preparation for test:browser

resolving closed store tests

test runs test:node and test:browser

browser tests

circleci updates

YAML fix

fixing conf directive in YAML

mocha-headless-chrome

Adding default keystore

Fixing browser tests and fixtures dir

Production mode browser

Final build

Linting

fix: verifier data to buffer

fix: search for key in try/catch

update build

Update level

make rebuild

Re-enabling linting

Restoring format
@aphelionz aphelionz force-pushed the fix/persistent-leveldb-connection branch from 9beae82 to e2fa543 Jul 30, 2019
@aphelionz aphelionz merged commit 995fede into master Jul 30, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.