Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default referenceCount from 64 to 32 #55

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@aphelionz
Copy link
Contributor

aphelionz commented May 13, 2019

This PR:

  • Reduces the default referenceCount option from 64 to 32, which gives a substantial gain in append performance due to less IPLD traversal.
  • Changes the caching schema to be by key instead of by store which further reduces unnecessary store opening/closing
  • Adds automated testing and CI for both node and the browser 馃帀
@aphelionz aphelionz mentioned this pull request May 31, 2019
10 of 10 tasks complete
@aphelionz aphelionz force-pushed the fix/store-performance branch 2 times, most recently from ff04580 to 69bae47 Aug 26, 2019
src/Store.js Outdated Show resolved Hide resolved
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Aug 27, 2019

@aphelionz looks good to me! 馃檹 Just a small suggestion in the comments + there are some new files created with make rebuild which can be added to .gitignore

@aphelionz aphelionz force-pushed the fix/store-performance branch from 06e9c01 to 40d836b Aug 27, 2019
fix: explicit path in cache

ipfs-log branch

final push

upgrading to new orbit-db-store and not closing cache

Some, but not all, tests

Adding CI files

Node tests first

Linting

webpack conf

Browser tests

Linting

Final changes

Mocha headless chrome

Using path module

New go-ipfs-dep, tests passing

Linting
@aphelionz aphelionz force-pushed the fix/store-performance branch from 40d836b to 3f755ac Aug 27, 2019
@aphelionz aphelionz merged commit 65061b4 into master Aug 27, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node Your tests passed on CircleCI!
Details
@aphelionz aphelionz deleted the fix/store-performance branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.