This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
Default referenceCount from 64 to 32 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
aphelionz
force-pushed
the
fix/store-performance
branch
2 times, most recently
from
ff04580
to
69bae47
Compare
shamb0t
reviewed
Aug 27, 2019
|
@aphelionz looks good to me! 🙏 Just a small suggestion in the comments + there are some new files created with |
aphelionz
force-pushed
the
fix/store-performance
branch
from
06e9c01
to
40d836b
Compare
fix: explicit path in cache ipfs-log branch final push upgrading to new orbit-db-store and not closing cache Some, but not all, tests Adding CI files Node tests first Linting webpack conf Browser tests Linting Final changes Mocha headless chrome Using path module New go-ipfs-dep, tests passing Linting
aphelionz
force-pushed
the
fix/store-performance
branch
from
40d836b
to
3f755ac
Compare
This was referenced Aug 28, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
referenceCountoption from 64 to 32, which gives a substantial gain in append performance due to less IPLD traversal.