Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Using identity's keystore as default first #677
This PR uses the keystore from
Additionally, it marks a cache as "default" which means the Store class won't close it, as opposed to a custom cache location created by passing in
Ok, pushed some more requested changed.
You can see examples of this in the tests and also in this
@aphelionz can you provide tests which fail that this PR fixes? It's still not clear to me that this is necessary. Are these essentially keystore and cache managers? Is it inconsistent to expect users to close cache/keystore themselves if they are non-default ones passed in?
Also can you elaborate on
What are the requested changes and what are the changes to the semantics around
package-lock pointing to branch more cache management stuff WIP Passing tests Removing static linking fixing tests and linting fixing package.json removing last debugger removing last debugger Adding keystore and cache getters PR comments Removing extraneous cache management Package files Closing caches using dbAddress as this.caches key new tests for store management Working but with slightly different semantics Rebuild package-lock Dependency updates removeHandler restoring db.close in replication status test package.json files move handler to orbitdb.caches Test updates Cache management cleanup use store.options.directory requestCache in onLoad and onDrop add status test Adding db to this.stores in onLoad and onDrop Working RC5 before rebase Updating package-lock restoring original replicaiton status test package files removing keystore getter more keystore cleanup typo