Using identity's keystore as default first #677

aphelionz · 2019-09-03T22:31:06Z

This PR uses the keystore from options.identity first in createInstance, and then looks for options.keystore

Additionally, it marks a cache as "default" which means the Store class won't close it, as opposed to a custom cache location created by passing in options.directory, which it will close.

src/fs-shim.js

src/OrbitDB.js

aphelionz · 2019-09-10T15:21:14Z

@haadcode I believe all the tests should pass now

aphelionz · 2019-09-13T20:12:19Z

Ok, pushed some more requested changed.

@haadcode @shamb0t Please have a look. I'm too deep in the weeds to think about it clearly / objectively and some of the requested changes require changes to our semantics around drop and close

You can see examples of this in the tests and also in this orbit-db-cache PR: orbitdb-archive/orbit-db-cache#14

src/OrbitDB.js

test/create-open.test.js

shamb0t · 2019-09-17T08:29:38Z

@aphelionz can you provide tests which fail that this PR fixes? It's still not clear to me that this is necessary. Are these essentially keystore and cache managers? Is it inconsistent to expect users to close cache/keystore themselves if they are non-default ones passed in?

Also can you elaborate on

some of the requested changes require changes to our semantics around drop and close

What are the requested changes and what are the changes to the semantics around drop and close?

src/OrbitDB.js

test/replication-status.test.js

src/OrbitDB.js

package-lock pointing to branch more cache management stuff WIP Passing tests Removing static linking fixing tests and linting fixing package.json removing last debugger removing last debugger Adding keystore and cache getters PR comments Removing extraneous cache management Package files Closing caches using dbAddress as this.caches key new tests for store management Working but with slightly different semantics Rebuild package-lock Dependency updates removeHandler restoring db.close in replication status test package.json files move handler to orbitdb.caches Test updates Cache management cleanup use store.options.directory requestCache in onLoad and onDrop add status test Adding db to this.stores in onLoad and onDrop Working RC5 before rebase Updating package-lock restoring original replicaiton status test package files removing keystore getter more keystore cleanup typo

aphelionz force-pushed the fix/createInstance branch from 4fed0f1 to e48e603 Compare September 4, 2019 22:10

aphelionz mentioned this pull request Sep 5, 2019

Release v0.22.0 #670

Closed

aphelionz force-pushed the fix/createInstance branch 5 times, most recently from 1e3edf0 to f23527f Compare September 5, 2019 14:46

aphelionz commented Sep 5, 2019

View reviewed changes

src/fs-shim.js Show resolved Hide resolved

haadcode reviewed Sep 6, 2019

View reviewed changes