Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer exchanged #763

Merged
merged 8 commits into from
Aug 24, 2020
Merged

Update peer exchanged #763

merged 8 commits into from
Aug 24, 2020

Conversation

msterle
Copy link
Contributor

@msterle msterle commented Feb 19, 2020

Bring #606 up to date

@msterle msterle requested review from aphelionz and removed request for aphelionz February 19, 2020 11:43
@msterle
Copy link
Contributor Author

msterle commented Feb 20, 2020

Interestingly, these tests pass when running locally, even without the updated orbit-db-store package, but fail here on the orbit-db CI. It's possible that this is the sort of timing condition that the peer.exchanged test was trying to capture, but I'll have to look into it more - ideally, the tests should pass or fail consistently, independent of environment.

@aphelionz
Copy link
Member

aphelionz commented Mar 7, 2020

@msterle Looks like we may have js-ipfs 0.41 support soon... that could help.

@msterle
Copy link
Contributor Author

msterle commented Mar 11, 2020

Test fixed by increasing the time between the final replicate event received and the test for number of peer.exchanged events.

@aphelionz
Copy link
Member

I'm curious now if the update from #782 will now fix this! Let's see if we can get it into 0.24.0.

This was referenced Apr 21, 2020
@aphelionz aphelionz added this to To Do in Release v0.24.0 Apr 22, 2020
@aphelionz aphelionz moved this from To Do to In Progress in Release v0.24.0 May 12, 2020
@aphelionz aphelionz moved this from In Progress to Ready for Release in Release v0.24.0 May 12, 2020
@aphelionz aphelionz removed this from Ready for Release in Release v0.24.0 May 26, 2020
@aphelionz aphelionz added this to To Do in Release 0.25.0 May 30, 2020
@aphelionz
Copy link
Member

@msterle would you mind rebasing this to the latest master? Super curious to see how the tests do

@aphelionz aphelionz moved this from To Do to In Progress in Release 0.25.0 May 30, 2020
@oed
Copy link
Contributor

oed commented Jun 10, 2020

@aphelionz Anything blocking this except the rebase?

@aphelionz
Copy link
Member

@oed I don't think so!

@oed
Copy link
Contributor

oed commented Jun 12, 2020

Updated @aphelionz, looks like tests are failing on master as well.

@aphelionz
Copy link
Member

@oed @msterle Any chance of getting this rebased one more time now that we have passing tests on master?

@oed
Copy link
Contributor

oed commented Aug 24, 2020

Done @aphelionz

@aphelionz aphelionz merged commit bd777c5 into orbitdb:master Aug 24, 2020
Release 0.25.0 automation moved this from In Progress to Done Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants