-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ready for js-ipfs >= 0.41 #767
Conversation
Cool! Can't wait to have a look at this |
Getting few errors here, although the tests still pass. It would still be prudent to deal with these before merging.
|
@@ -61,7 +61,7 @@ The default keystore and identity-provider now have caches added to speed up ver | |||
|
|||
### Offline mode | |||
An optional `offline` flag has bee added which, when set to `true`, prevents pubsub from starting and messages from being exchanged. This is useful to speed up testing and for when you would like to use your database locally without networking enabled. | |||
To use offline mode, start your IPFS nodes offline (with `new IPFS({ start: false })`) and create your OrbitDB instance as follows: | |||
To use offline mode, start your IPFS nodes offline (with `IPFS.create({ start: false })`) and create your OrbitDB instance as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing doc updates 👍
Provisional approval pending on the above comment about the errors. Need to discuss and work through those |
I believe this is the list of repos that need to be updated to |
I don't think we need to update |
Even though you were extremely diligent about backwards-compatibility in |
Just the feedstore is left! |
Still need to deal with those errors above as well 🤔 |
Go ahead and bump the version to |
Yes, even more errors
|
Ok, let me see what I can do with those before I publish |
I think we can simply ignore those things, only occur when receiving headers from the network. |
Adding concurrency limit on the _onMessage callback may be a better way to solve the |
What's the status of this? @Xmader @aphelionz |
According to its changelog, js-ipfs 0.42.0 did not change much from 0.41. |
If that's the case then why not support the latest? Is that what you mean? |
Yes |
Ok great, we can republish all the transient dependencies as patch versions |
Pinging here again :) Ipfs was updated to |
Adapting the packages from the bottom up has begun! I'm doing a sweep of all of them and fixing stuff as I go. Check out orbitdb-archive/orbit-db-test-utils#11 |
Any progress? This is really screwing us right now: ipfs/js-ipfs#2986 |
I think a reasonable ETA on this is sometime next week |
Any latest status, thanks? |
Afaik this PR is outdated, and superseded by #794. |
@dkent600 also there is an |
@phillmac Thanks for your response.
It seems that IPFS will no longer be a dependency at all, according to https://github.com/orbitdb/orbit-db/pull/794/files:
I don't work for 3box, am just waiting for you to release the fix, and for 3box to pick it up. The reason the devDependency is relevant is because the problem occurs when Heroku, in creating a review app, tries to copy all (dev)dependencies and ends up creating a "slug" that exceeds Heroku's max size limit, because of the problem in IPFS's packaging. |
|
Should be fine as long as it is v >= 0.41 |
Yup, it's |
Any ETA on https://github.com/orbitdb/orbit-db/pull/794/files ? |
Still working through some pretty significant issues, so if you can use |
Thanks @aphelionz I think we will prepare for the update using |
Closing this as we are up to 0.46 now. Thank you for the effort @Xmader !! |
close #762