Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add GitHub niceties to this repo #32

Closed
4 tasks done
aphelionz opened this issue Jan 8, 2019 · 9 comments
Closed
4 tasks done

Add GitHub niceties to this repo #32

aphelionz opened this issue Jan 8, 2019 · 9 comments
Assignees

Comments

@aphelionz
Copy link
Contributor

aphelionz commented Jan 8, 2019

  • Add issue template
  • Add PR template
  • Review README for compliance
  • Integreate tests and PRs with CircleCI
@yindia
Copy link
Contributor

yindia commented Jan 8, 2019

Review ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE

@yindia
Copy link
Contributor

yindia commented Jan 8, 2019

@aphelionz also add codeclimate config for all PR

@aphelionz
Copy link
Contributor Author

Hadn't seen codeclimate! I'll check it out.

@RichardLitt
Copy link
Contributor

I'm not sure we need the templates, for now, given the low-bandwidth of this repo. The README looks fine to me.

How are tests and PRs going with CircleCI, @latenssi?

@latenssi
Copy link
Contributor

@RichardLitt atm we do not have CircleCI integration in this repo.

@RichardLitt
Copy link
Contributor

Aight. Should we keep this open?

@aphelionz
Copy link
Contributor Author

I think @latenssi and @JaniAnttonen might want to get eyes on the PR and Issue templates that @evalsocket suggested. They might have more insight about what is / isn't needed there. Other than that, I think it's good.

@RichardLitt
Copy link
Contributor

Those look fine to me, but I think, given the low traffic in this repo at the moment, it's not really time for the templates yet. However, thank you, @evalsocket!

@latenssi if you agree, go ahead and close this. :)

@JaniAnttonen
Copy link
Contributor

e2e tests added in #66

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants