Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Latest commit

聽

History

History
192 lines (125 loc) 路 9.65 KB

contributing.md

File metadata and controls

192 lines (125 loc) 路 9.65 KB
Raw

Contributing

Want to hack on OrbitDB? Awesome! Here are instructions to get you started. They are not perfect yet. Please let us know what feels wrong or incomplete.

OrbitDB is an Open Source project and we welcome contributions of all sorts. There are many ways to help, from reporting issues, contributing code, and helping us improve our community.

Table of Contents

Security Issues

The OrbitDB protocols and their implementations are still in heavy development. This means that there may be problems in our protocols, or there may be mistakes in our implementations. We take security vulnerabilities very seriously. If you discover a security issue, please bring it to our attention right away!

If you find a vulnerability that may affect live deployments -- for example, expose a remote execution exploit -- please send your report privately to security@orbitdb.org. Please DO NOT file a public issue.

If the issue is a protocol weakness or something not yet deployed, just discuss it openly.

Community Guidelines

We want to keep the OrbitDB community awesome, growing and collaborative. We need your help to keep it that way. To help with this we've come up with some general guidelines for the community as a whole:

  • Be nice: Be courteous, respectful and polite to fellow community members: no regional, racial, gender, or other abuse will be tolerated. We like nice people way better than mean ones!

  • Encourage diversity and participation: Make everyone in our community feel welcome, regardless of their background and the extent of their contributions, and do everything possible to encourage participation in our community.

  • Keep it legal: Basically, don't get anybody in trouble. Share only content that you own, do not share private or sensitive information, and don't break laws.

  • Stay on topic: Make sure that you are posting to the correct channel and avoid off-topic discussions. Remember when you update an issue or respond to an email you are potentially sending to a large number of people. Please consider this before you update. Also remember that nobody likes spam.

There is also a more extensive Code of conduct which we follow.

Moderation

In cases where community members transgress against the values above or in the Code, members of the OrbitDB Community Moderation team will use a three-strike warning system, where the aggressor will be warned twice before they are permanently excluded from OrbitDB community spaces. This code applies to Gitter, IRC, and GitHub, and any other future space that the OrbitDB community uses for communication. For interactions between OrbitDB community members outside of this space, the code also applies if the interactions are reported and deemed to be interfering with community members safely working on OrbitDB together. Moderation conversations, where more serious than simple warnings, will occur in private repositories or by email to ensure anonymity for reporters, and to ensure the safety of the moderators. To report an instance, please see the emails in the Code of Conduct.

Reporting Issues

If you find bugs, mistakes, inconsistencies in the OrbitDB specs, code or documents, please let us know by filing an issue at the appropriate issue tracker. No issue is too small.

Protocol Design

When considering protocol design proposals, we are looking for:

  • A description of the problem this design proposal solves
  • Discussion of the tradeoffs involved
  • Review of other existing solutions
  • Links to relevant literature (RFCs, papers, etc)
  • Discussion of the proposed solution

Please note that protocol design is hard, and meticulous work. You may need to review existing literature and think through generalized use cases.

Implementation Design

When considering design proposals for implementations, we are looking for:

  • A description of the problem this design proposal solves
  • Discussion of the tradeoffs involved
  • Discussion of the proposed solution

Community Improvement

The OrbitDB community requires maintenance of various "public infrastructure" resources. These include documentation, GitHub repositories, CI build bots, and more. There is also helping new users with questions, spreading the word about OrbitDB, and so on.

A small note on licensing year

Please don't update the year in the license files. Our policy is:

  • Don't remove dates already in notices.
  • Don't bother adding dates in new notices.
  • Don't bother updating years in notices.

Thanks.

Translations

This community moves very fast, and documentation swiftly gets out of date. If you would like to add a translation, please open an issue and ask the project captain for a given repository before filing a pull request, so that we do not waste efforts.

If anyone has any issues understanding the English documentation, please let us know! If you would like to do so privately, please email @RichardLitt. We are very sensitive to language issues, and do not want to turn anyone away from hacking because of their language.

Creating new modules

We're a UNIX-friendly organization; we love making lots of small modules that do one thing well, instead of a large monorepo that does a lot of things at the same time. As such, we'll occasionally create new repositories. If you're interested in tackling some of these design problems and starting a new module from scratch, get in touch on the community calls or through an issue here. As well, if you're interested in having your relevant module be part of the @orbitdb organization, open an issue suggesting that you move it over. You'll retain copyright! We would love to have as many relevant packages as possible together.

If you're creating a new repository, please follow the new repository guidelines orbitdb/repo-template.

Linting

When contributing code, please "lint first and ask questions later." We use https://standardjs.com to lint our code.

  1. Install standard:
$ npm i -D standard # npm install --save-dev standard
  1. Add the lint script to package.json.
{
  "scripts": {
    "lint": "standard --env=mocha"
  }
}
  1. Run standard --fix to fix current issues.
$ npx standard --fix
  1. Run the linter.
$ npm run lint

Note: If you'd rather have the environment set permanently (for instance, so that your editor can notice it), add this to the package.json:

{
 "standard": {
   "env": [
     "mocha"
   ]
 }
}

You can also exclude files:

{
 "standard": {
   "ignore": "lib/es5/**/*.js"
 }
}

For extra credit, install jq and sponge from GNU's moreutils and do it in one line:

$ jq '.scripts.lint="standard --env=mocha"' package.json | sponge package.json

Submitting a PR

When submitting a PR, keep these things in mind:

  • This is open source. We're working on it! We try to get to PRs as often as we can, but if we don't respond for a few days, feel free to politely ping.
  • Add tests! The more, the better. We aim for 110% code coverage for testing. Turn your tests up to 11.
  • Lint first, ask questions later. When submitting a PR (or creating a new repository), please adhere to the standard style. This helps us cut down on bike shedding immensely.
  • Open an issue to discuss big PRs before making them. We don't want your work to be undercut by a simple workaround we could have implemented before! Discussion is the best way to ensure you're on the right track.

Email List

We do not have an email listserv; all of our conversation is in GitHub. If you would like one, please post in this issue.

Becoming a maintainer

If you want to help us with triaging issues, merging PRs, writing code, and maintaining repositories, we would be overjoyed. Maintenance is hard work, and all of the help that we can get from contributors is appreciated. Becoming a maintainer is currently an informal process - stick around for a while, help out where you can, and show the core team that you're interested in more than just having the OrbitDB logo on your GitHub profile. Then, reach out to one of the devs to ask to be included as a maintainer.

Occasionally, we'll give people access rights straight out of the gate because they have proved themselves before, or because they're the most logical choice for maintainership for certain repositories. For instance, if you wrote a Groovy implementation of OrbitDB, and you want to move it into the OrbitDB organization, you'll retain your maintainer rights for that repository.

If you ever feel that someone should not have maintainer rights, send an email to the community team. Let's talk about it together.