Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotary switches should cycle through sequentially, not to the clicked position. #315

Closed
rcflyinghokie opened this issue Mar 26, 2018 · 1 comment

Comments

@rcflyinghokie
Copy link
Collaborator

Rotary switches in the LM (and the CM, just change the behavior of the class) should be changed so that the new position does not snap to the position clicked, but rather through all positions until the desired position is reached, similar to that of a three position switch. While this was convenient, it messes with checklist flows which plan for and anticipate cycling through other positions to get to the desired one.

For example, in the LM glycol pump test, a comp light is expected when cycling from SEC to Pump 2, however since clicking Pump 2 makes the switch select it right away, you do not get the expected results.

@ThymoNL
Copy link
Member

ThymoNL commented May 14, 2018

Some code should already account for this (EMS) by cycling through the positions internally.
Maybe this can be propagated to the systems not doing this as a less invasive approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants