Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed in D3D9surface.cpp at Line 843 when going down to LEB #338

Closed
ggalfi opened this issue Apr 7, 2018 · 4 comments
Closed

Comments

@ggalfi
Copy link
Contributor

ggalfi commented Apr 7, 2018

Hi all,

Using the actual Orbiter2016 branch I get the following error followed by CTD when I try to go down to LEB:
image
Seem to me the problem caused by a 30. Mar change in the saturnpanel.cpp (commit 7a5c7e4), in which the CSM MFD-s (4 in the LEB) were resized. The two MFDs under the main panel are fine anyway.

Reverting the changes in the saturnpanel.cpp solved this problem for me, so I suggest doing something similar in the active branch as well.

Cheers,
Gergely

@indy91
Copy link
Contributor

indy91 commented Apr 7, 2018

That's a good bug report, I think jalexb88 will know how to fix this. Thanks!

@indy91
Copy link
Contributor

indy91 commented Apr 7, 2018

#339 probably fixed this issue. Can you confirm that?

@jalexb88
Copy link
Contributor

jalexb88 commented Apr 7, 2018

OK, so I have noticed that it the case where split panels are used in the CSM LEB, the left most of the 4 MFDs went off the left border of the middle LEB panel. So I shifted the MFDs to the right by a few pixels and that makes them display correctly. ggalfi, I have made a pull request to the main repo, and once its merged and the auto build complete, you can download the updated alpha release (or rebuild yourself). Let me know if that fixes it!

@ggalfi
Copy link
Contributor Author

ggalfi commented Apr 7, 2018

I've built the current version and it indeed solved the problem. I can now enter to the LEB, and all four MFDs appear flawlessly. Thanks, great job!

@ggalfi ggalfi closed this as completed Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants