store.cache.query(q => q.findRecords('foo')) should validate 'foo' is defined in schema

[mindblight]

If foo is not defined in a Stores schema, calling store.cache.query(q => q.findRecords('foo')) throws:

withQuery.tsx:35 Uncaught TypeError: Cannot read property 'values' of undefined
    at findRecords (query-operators.js:18)

It looks like the problem is at line 40 of store/src/cache/query-operators.ts:

let results = Array.from(cache.records(expression.type).values());

cache.records returns undefined which makes .values() throw the above error, which isn't obvious what the problem is. Something like Store could not find 'foo' definition in cache. Did you forget to add it to your schema? would be more helpful. It looks like the other find operations all have a similar version of this.

I'm happy to throw together a PR with the check in place, but I wanted to get thoughts/feedback first.

[dgeb]

@mindblight It will be good to improve orbit's DX for common issues like this, so that minor papercuts don't turn into major frustrations.

I agree that your suggestion would be an improvement. Please let me know if you need any guidance in putting together the PR. Thanks!

[stefan-wullems]

Is this completed yet? If not I'll make some time to give it a go. I've ran into some pretty frustrated bugs because of this.

[dgeb]

@Stefanwullems I don't think this has been tackled yet, so it would be much appreciated if you could improve the DX here. Thanks in advance!