Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argument->build->protocol seems a bit complicated. #26

Open
noambergIL opened this issue Oct 23, 2019 · 0 comments
Open

argument->build->protocol seems a bit complicated. #26

noambergIL opened this issue Oct 23, 2019 · 0 comments

Comments

@noambergIL
Copy link
Contributor

When we translate from Argument (src/codec/Arguments.ts func argumentsBuilders) to Builder (src/protocol/Protocol.ts ctor)
we take apart the arg and use switch over the type as string to create a builder where the type is number ... this seems unneeded ...
why not just push the switch over string into the builder ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noambergIL