Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of command override in docker/test/docker-compose.yml #1418

Open
amir-arad opened this issue Nov 3, 2019 · 0 comments
Open

get rid of command override in docker/test/docker-compose.yml #1418

amir-arad opened this issue Nov 3, 2019 · 0 comments

Comments

@amir-arad
Copy link

docker/test/docker-compose.yml overrides default command line of each container in order to customize confiuguration. It's cumbersome, as the main entry point should remain an implementation detail of the image.

Our images should read all necessary arguments from environment variables (and/or config files) to support this use case. and docker-compose config should use it.

see @netoneko 's comment on #1411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant