Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization postponed in ValidateBlockForCommit #684

Closed
ronnno opened this issue Jan 7, 2019 · 1 comment
Closed

Optimization postponed in ValidateBlockForCommit #684

ronnno opened this issue Jan 7, 2019 · 1 comment
Assignees
@gadcl @OdedWx

Comments

@ronnno
Copy link
Member

ronnno commented Jan 7, 2019

  • Spec describes optimization to perform structural verification on blocks in BlockStorage
  • Optimization is out of scope for V1
  • Spec should be updated to reflect that (https://tree.taiga.io/project/orbs-network/us/438?kanban-status=1639113)
  • When implementing optimization HandleBlockConsensusInput should change to exclude results and transactions blocks and include only block proof. And, structural verification should be done on BlockStorage side before notifying ConsensusAlgo
@ronnno ronnno self-assigned this Jan 7, 2019
@electricmonk electricmonk assigned gadcl and OdedWx and unassigned ronnno Aug 14, 2019
@electricmonk
Copy link
Contributor

@OdedWx @gadcl is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gadcl gadcl

@OdedWx OdedWx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@electricmonk @gadcl @ronnno @OdedWx