first OpenLayerMap files: Draft PR. *notes in OpenLayerMap.tsx* #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are migrating from Mapbox to OpenLayerMap right? |
|
This is a spike, but it is looking good so far for OpenLayers. It has vector layers which might come in handy. |
…tructor calls, cleaned up code, debugged TS, commented at points of interest
|
This PR is now available for a test drive, it needs an extra 'npm install' if you already have the project running locally, as it uses two new dependencies. |
ivanoats
reviewed
Mar 13, 2021
|
Merging and closing, everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on integrating an OpenLayer map into the project, converting an example into Typescript along the way.
Progress notes -
'OpenLayerMap.tsx' made for 'Map.jsx' in guide.
needs: