Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New home view #1485

Merged
merged 61 commits into from Jan 20, 2023
Merged

New home view #1485

merged 61 commits into from Jan 20, 2023

Conversation

mausworks
Copy link
Member

@mausworks mausworks commented Dec 21, 2022

Description

This removes the /projects view in favor of a new more flexible "home" view, where other things than Projects can be displayed, such as all Job and Interactive Runs.

Features

  • Remove the /projects page and fix any inbound links
  • Redirect /projects to /?tab=projects
  • Move projects to the new home page and align components with new design
  • Update the Project selector menu with the new design
  • Implement interactive job runs under "all runs"
  • Implement all job runs under "all runs"
    • Make the back-end support querying of multiple (or all) projects
    • Implement filtering, pagination, etc... in the new front-end based on the new API.

Checklist

  • I have manually tested my changes and I am happy with the result.
  • The documentation reflects the changes.
  • The PR branch is set up to merge into dev instead of master.

@mausworks mausworks added the improvement An improvement or enhancement to an existing feature. label Dec 21, 2022
@mausworks mausworks marked this pull request as draft December 21, 2022 15:50
Components are re-implemented according to new design
@mausworks
Copy link
Member Author

Seems like there is no polling, because the view doesn't update for me

@ricklamers haha, no you're right. 🤦 😂

Fixed: f8c2263

@fruttasecca
Copy link
Member

fruttasecca commented Jan 17, 2023

image I'm hitting a snag with orchest-api not coming up. Also doesn't produce log. Retried as clean installation, no luck. @fruttasecca did you experience this at some point?

Update: I expect this to be a migration conflict related to Alembic. Was able to resolve when I made sure I started without state and installing directly from dev only after building all container images.

I believe the cause is/are branching migrations between what's on dev and this branch, easily fixed/verified, e.g. try bash scripts/migration_manager.sh orchest-api merge heads

Use `useCurrentQuery`, `useActiveProject`, `useActivePipeline` instead.
When set to true, it will run the `hydrate` function each time it updates.
This is useful when fetching by some UUID.
@mausworks
Copy link
Member Author

Is showing 5 per page the default? Seems a bit low. Maybe go with 10?

@ricklamers updated to 8 now! Do you still think 10?

@mausworks
Copy link
Member Author

Creating a new project in the project drawer gives me:

@ricklamers this is also fixed now 👍

@mausworks
Copy link
Member Author

@iannbing

Quite a big PR to review even per commit.

Yeah, I'm sorry. The PR touches on pretty much every entity in some way (examples, projects, jobs, pipelines, job runs), making it naturally quite large. 😬

there are definitely some work to be done regarding the inconsistency between the old contexts and the new zustand stores.

I have now removed projectUuid, project, pipeline, and pipelines from the project context entirely. useActiveProject, useActivePipeline, useProjectPipelines can be used instead. projectUuid is available in useCurrentQuery.

Just set `timeout` (previously `duration`) to 500 by default.
@ricklamers
Copy link
Member

ricklamers commented Jan 20, 2023

When I load a project the main pipeline is not loaded:

image

I just created a new project, added a step to the pipeline and clicked on JupyterLab.

E.g. clicking the pipeline in the pipeline sessions element in the lower left corner doesn't open the pipeline either.

Console:

image

Warning FailedMount 0s (x7 over 32s) kubelet Mo │
│ untVolume.SetUp failed for volume "ssh-key-5615fd61-52b3-4a4d-b │
│ ed6-4c0297bccd11" : secret "ssh-key-5615fd61-52b3-4a4d-bed6-4c0 │
│ 297bccd11" not found

Looks like this was because of some old state related to SSH keys

@ricklamers
Copy link
Member

LGTM! @mausworks for pres

@mausworks mausworks merged commit ecdb482 into dev Jan 20, 2023
@mausworks mausworks deleted the feat/new-home branch January 20, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement or enhancement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants