New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve robustness of Orchest Operator and update mechanism #966
Merged
yannickperrenet
merged 105 commits into
dev
from
feat/controller-fix-deployment-order-readiness
May 27, 2022
Merged
Improve robustness of Orchest Operator and update mechanism #966
yannickperrenet
merged 105 commits into
dev
from
feat/controller-fix-deployment-order-readiness
May 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhaghighat
force-pushed
the
feat/controller-fix-deployment-order-readiness
branch
from
May 22, 2022 14:24
56b6947
to
31de0ee
Compare
In case you want to test it: ```bash orchest uninstall scripts/build_container.sh -M -t "v2022.04.4" -o "v2022.04.4" orchest install --dev orchest patch --dev pnpm run dev scripts/build_container.sh -M -t "v2022.04.5" -o "v2022.04.5" INVOKE THROUGH UI (go to http://localorchest.io/update) ```
This change does result in very poor logging messages on update. It does still satisfy the main requirement of indicating an update so that the user knows it is not stuck.
…ub.com:orchest/orchest into feat/controller-fix-deployment-order-readiness
Otherwise the install and the controller manifest will both try to create the namespace, which won't work.
…ub.com:orchest/orchest into feat/controller-fix-deployment-order-readiness
Fixes: #991 |
nhaghighat
added
the
improvement
An improvement or enhancement to an existing feature.
label
May 26, 2022
This was referenced May 26, 2022
yannickperrenet
deleted the
feat/controller-fix-deployment-order-readiness
branch
May 27, 2022 08:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
PR introduces breaking changes
improvement
An improvement or enhancement to an existing feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes order of deployment by introducing new internal CRD named
OrchestComponent
. TheOrchestCluster
will be created by the user or theorchest-cli
, thenOrchestCluster
controller creates differentOrchestComponent
for each service, then a dedicated component controller for each component, controls the status of the underlying objects ofOrchestComponent
Fixes: #952, #991
Testing the PR
Testing
orchest update
through the CLITesting
orchest update
through the UINOTE: You need to have created the minikube with the orchest-dev-repo mount
Checklist
dev
instead ofmaster
.orchest-cli
I followed its releasechecklist
compatibility is maintained.
requirements.in
I have runpip-compile
to updatethe corresponding
requirements.txt
make possible through CLI to specify it as well as--> To be done later so we can get this PR merged.singleNode
installation.orchest-cli
use the manifest from release assetskubectl
warning (Not needed)orchest update
through CLIorchest update
through UIUpdateView.tsx
needs to parse the response from the controller endpoint correctly and show it as logsorchest restart
through CLI and UIorchest patch
orchest install
Running
stateNote that the docker-registry is managed through Helm and not the orchest-controller.Mention in docs that pvc size can only be increased & that the default storage class is used if not specified.--> Will be added to the CLI in another PRorchest-controller
doesn't seem to be picking up custom namespacesorchest uninstall
might need to change slightly. If we choose to go for it, then there should be a default flag.