Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: raw --ts-pr-min: $padding-x SASS variable present in css dist files #683

Open
a-maas opened this issue Jan 23, 2024 · 1 comment · May be fixed by #684
Open

[Bug]: raw --ts-pr-min: $padding-x SASS variable present in css dist files #683

a-maas opened this issue Jan 23, 2024 · 1 comment · May be fixed by #684
Labels
bug Something isn't working stale No activity

Comments

@a-maas
Copy link

a-maas commented Jan 23, 2024

Bug description

I noticed that in the package's dist/css/tom-select.default.css file, the following CSS was present, which I believe is invalid:

.ts-wrapper.multi.has-items .ts-control {
  padding-left: 5px;
  --ts-pr-min: $padding-x;
}

Specifically $padding-x;, which I think is a SASS variable that didn't get properly replaced.

Looking at the source code, I believe the SASS variable should be wrapped in #{}, as referenced from here.

Expected behavior

The value of --ts-pr-min should be the value of the $padding-x sass variable, not a string $padding-x.

Steps to reproduce

  1. View dist file in the page from npm
  2. Look in dist/css/tom-select.default.css on line 449.

Additional context

Using tom-select 2.3.1 with vite 4.3

@a-maas a-maas added the bug Something isn't working label Jan 23, 2024
Copy link

This issue has not been active in 120 days and has been marked "stale". Remove stale label or comment or this will be closed in 15 days

@github-actions github-actions bot added the stale No activity label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant