Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown doesn't scroll to active option #88

Closed
oyejorge opened this issue May 16, 2021 · 2 comments
Closed

Dropdown doesn't scroll to active option #88

oyejorge opened this issue May 16, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@oyejorge
Copy link
Member

Describe the bug
Dropdown doesn't scroll to active option. See compiler-explorer/compiler-explorer#2666

@oyejorge oyejorge added the bug Something isn't working label May 16, 2021
@mattgodbolt
Copy link

Oh sweet, do you think this, plus #87 will fix the Compiler Explorer issues? I'd love to get that PR merged and live on the site! :)

@oyejorge
Copy link
Member Author

I think there are two things on your list that won't be covered.

Same width issues as the OG thing ("clang assertions" very wide etc)

Possible solution:

 .ts-dropdown{
width: 500px; // or whatever width you want
}

Ideally adding stuff to favorite should keep everything scrolled as it was (confusing to have things slip down)

The slip down is caused by new options (the new favorite) being added to the top of the dropdown list. To prevent the slip, there would have to be some additional code to adjust the dropdown scroll position after new options are added to the top of the dropdown.

I'd love to get that PR merged and live on the site! :)

I would too! I've found a few other things that need to get fixed but I'm almost done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants