v10?

[crogonint]

Someone shared this on the FoundryVTT subReddit, and reports are coming in about people being confused because it's not working in v10. Think you can check on that?

[brunocalado]

Keep a module to an old FVTT version and the current one could give the dev extra work.

[orcnog]

Sigh. I'm going to have to change the listed compatibility of this module to just v11 for now.

I mistakenly assumed it would work with at least v10... I guess I was wrong on that. Unfortunately I don't have the bandwidth right now to backup and roll back my whole FVTT setup just to test this, let alone switching back and forth between versions while I try to support both. If there was a way (and I'm sure there is, but I don't know of it) to have both v10 and v11 running at the same time, I would commit to fixing this. But someone will need to reach out to me and show me how to set that up, if it's possible.

I wish I could share this cool module with as many users as possible, and I know tons of users are still putting off the upgrade to v11. If another dev take up that charge, I'd be grateful. Otherwise, if it's not in the cards (see what I did there?) then just rest assured that when you do upgrade, you'll have a beautiful way to view cards in v11.

[kristianserrano]

This is interesting. It worked for me on V10 except for issue #10 and if multiple cards were dealt, they displayed vertically (I thought they were supposed to display horizontally).

[kristianserrano]

Oh, and the macros compendium was empty, but I suspect that's an easy fix.

[kristianserrano]

So it looks like the macros compendium was created using v11. If you recreate the compendium pack in v10 instead and use that database, it'll work across both v10 and v11.

[orcnog]

Oh that's fantastic news. I've updated the macros and I'm now trying to figure out how to translate the compendium to v10 (.db files). If I'm unable to, maybe after my next release (tonight), if anyone running v10 wants to zip up their current (untouched) modules/orcnog-card-viewer/packs folder and send it over, I should just be able to implement that as-is for v10 compatibility.

[kristianserrano]

If you can send me JSON exports of the macros, I can work on building a Compendium pack with them and commit it to the repo.

Actually I have a v11 instance. I can get them from there.

[Razortide]

So I receive the "No deck by that name was found". See screen

Hope that helps.

[kristianserrano]

I noticed that as well. From what I quickly looked at, it seems every time it's executed, an instance is created which includes getting a matching deck based on a name that's passed in, but it does this multiple times (noticed this when I put a breakpoint there in devtools) for some reason, and after the first, there's no value. I've only taken a cursory look though and I don't fully understand the entirety of the code yet.

[orcnog]

So I receive the "No deck by that name was found".

Hmm, based on the stack trace, this might be old code. hooks.mjs line #132 was what we just fixed in the last release (@kristianserrano found the typo).

Try installing the latest module release and retry that, @Razortide

[Razortide]

Unfortunately, I can't since you set the requirement to V11. @orcnog

[orcnog]

Unfortunately, I can't since you set the requirement to V11. @orcnog

@Razortide I got you. https://github.com/orcnog/orcnog-card-viewer/releases/download/v0.1.6/module.json
That release is just for testing v10. (I bumped the version compatibility down to v9).

Just manually install this following these steps:

1. Click on the Add-on Modules tab.
2. Click the Install Module button.
3. Paste the above link as the manifest URL in the field at the bottom of the dialog.
4. Click Install.

[kristianserrano]

Moved this comment to the PR

[Razortide]

Hey @orcnog that worked like a charm. Thank you so much! So, I can confirm, that for me it's working. Shall I remove it and wait for an official release then?

[orcnog]

New package is available now, allowing installs in v10, and containing this card size fix (and plenty more).
https://github.com/orcnog/orcnog-card-viewer/releases/tag/v0.1.7

[orcnog]

Oops, closed this one when I meant to close Issue #18. v10 support is still an ongoing effort.