Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable substitution not working if any empty line in .nontemplates #19

Closed
xingyuli opened this issue Sep 19, 2017 · 2 comments
Closed

Comments

@xingyuli
Copy link

xingyuli commented Sep 19, 2017

This weird behavior happens if there any empty line in the .nontemplates file:

**/*.jar
**/*.bat
**/*.sh
**/*.zip
**/*.gz
**/*.xz
**/*.tar
**/*.7z

gradle/
.gradle/
gradlew
gradlew.bat

You can reproduce the bug simply by modifying the .nontemplates and run command against your sample project:

$ gradle cleanArch generate

$ cat generated/settings.gradle
include "@projectName@-model", "@projectName@-web"

// @packagePath@
// @groupPath@/@namePath@
// @name.capitalize()@
// @new Date()@

Circumstances are I want to add more patterns to .nontemplates, and use empty(or blank) lines to make it easier for grouping purpose. I came across this problem just in that case, and finally find the bug. Either this behavior should be mentioned in the README or be fixed.

@xingyuli
Copy link
Author

Also, supporting comments (e.g., lines start with '#') is expected, but I didn't test against that yet.

@orctom
Copy link
Owner

orctom commented Sep 19, 2017

Checkout version 1.4.6

@orctom orctom closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants