Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using slider "WARangeSlider" in dialog #139

Closed
ahmedAlmasri opened this issue May 6, 2017 · 12 comments
Closed

using slider "WARangeSlider" in dialog #139

ahmedAlmasri opened this issue May 6, 2017 · 12 comments

Comments

@ahmedAlmasri
Copy link

ahmedAlmasri commented May 6, 2017

Report

using slider "WARangeSlider" in dialog swipe not working

Environment

Please provide information on your development environment, so we can build with the same scenario.

  • Mac OS version 10.12
  • Xcode version 8.0
  • PopupDialog version 0.5.4
  • Minimum deployment target 9.0
  • Language (Swift)
  • In case of Swift 3.1

Dependency management

If you are not using any dependency managers, you can remove this section.

Please note: If you are using CocoaPods with Xcode 8, CocoaPods 1.1.0 is required.

  • Dependency manager CocoaPods
  • Version (1.1.0)

untitled-1
.

@mwfire
Copy link
Member

mwfire commented May 9, 2017

Hey there! Could you please provide a small example project. I cannot reproduce this right now.

Many thanks!

@ChanchalW
Copy link

Hi i am also facing this issue. My range slider is hanging.

@mwfire
Copy link
Member

mwfire commented Jun 13, 2017

Hi @ChanchalW, could you please provide a small sample project showcasing the error?

Thanks!

@ChanchalW
Copy link

Sure

@ChanchalW
Copy link

ChanchalW commented Jun 15, 2017

Could you please check mail

@mwfire
Copy link
Member

mwfire commented Jun 15, 2017

Thanks @ChanchalW, I will look into this over the coming days!

@ChanchalW
Copy link

ChanchalW commented Jun 15, 2017

Can you please suggest me any workaround for now, else i have to remove these classes, its very urgent. I committed to give delivery today.

@mwfire
Copy link
Member

mwfire commented Jun 15, 2017

Ok, one thing we can try is:

Look up tapRecognizer.cancelsTouchesInView = false in PopupDialog source
Add panRecognizer.cancelsTouchesInView = false below, while unlocking the file.

Does that help?

@ChanchalW
Copy link

ChanchalW commented Jun 15, 2017

Ok thanks , I disabled gesture dismiss and dismiss it on button click. Now its working smooth.
And one more thing its also leg if table view is used in popup, it slow down its scrolling speed.

@kylebrowning
Copy link

kylebrowning commented Jun 26, 2017

Setting panRecognizer.cancelsTouchesInView = false Fixes this issue for your example in the PopupDialog-Example.

@ChanchalW
Copy link

Yes

@mwfire
Copy link
Member

mwfire commented Jun 27, 2017

Thanks for checking this out, I will add this to the next release.

Cheers
Martin

@mwfire mwfire added this to TODO in Version 0.5.5 Jun 27, 2017
@mwfire mwfire moved this from TODO to In Progress in Version 0.5.5 Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Version 0.5.5
In Progress
Development

No branches or pull requests

4 participants