Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe rename --data-dir to --datadir #3273

Closed
casey opened this issue Mar 12, 2024 · 5 comments
Closed

Maybe rename --data-dir to --datadir #3273

casey opened this issue Mar 12, 2024 · 5 comments
Labels
good first issue

Comments

@casey
Copy link
Collaborator

casey commented Mar 12, 2024

The extra dash is annoying, and I read it as one word anyways.
@chasefleming
Copy link
Contributor

chasefleming commented Mar 13, 2024 •
edited
Loading

@casey I can take this one. Should we make data-dir an alias so it's a non-breaking change?

@raphjaph
Copy link
Collaborator

yeah why not, should be easy enough with clap

@chasefleming chasefleming mentioned this issue Mar 13, 2024
Merged
@chasefleming
Copy link
Contributor

@raphjaph I added the alias and switched the recommended usage in the docs. Do you also want data_dir switched to datadir internally or to leave as-is?

@raphjaph
Copy link
Collaborator

We can leave it internally as is

@chasefleming
Copy link
Contributor

Awesome, thanks @raphjaph !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@casey @chasefleming @raphjaph