Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should inscriptions be optional in batchfile? #3396

Closed
rot13maxi opened this issue Mar 28, 2024 · 9 comments
Closed

should inscriptions be optional in batchfile? #3396

rot13maxi opened this issue Mar 28, 2024 · 9 comments

Comments

@rot13maxi
Copy link
Contributor

Right now a batch file requires inscriptions . Since the interface for etching runes is through the inscribe command, should we allow this to be optional if you only want to etch runes and are not trying to inscribe something? I'm happy to write the PR, want to make sure there's not an intent here that I'm missing before I go make all the updates

@raphjaph
Copy link
Collaborator

I think this would be a great addition!

Since we use the inscription envelope for the commit/reveal of the rune name. It would have to create an inscription with no content. And then on the runes page, if the inscription has no content, it shouldn't be shown

@raphjaph raphjaph reopened this Mar 29, 2024
@casey
Copy link
Collaborator

casey commented Mar 29, 2024

I think if we do this, the inscriptions field should still be present, but marked somehow as having no content, since creating a rune will still create an inscription, to store the commitment.

@GiantDole
Copy link

+1 on this feature :)

@0xprames
Copy link

0xprames commented Apr 9, 2024

+1

@raphjaph
Copy link
Collaborator

Closed by #3451

@gus4rs
Copy link

gus4rs commented Apr 13, 2024

@raphjaph inscriptions are still required in the batch file

error: missing field `inscriptions` at line 23 column 1
ord --version
ord 0.18.1

@raphjaph
Copy link
Collaborator

you can do:

inscriptions:
-

It's a bit janky for now but works.

@gus4rs
Copy link

gus4rs commented Apr 18, 2024

It creates an inscription s

you can do:

inscriptions:
-

It's a bit janky for now but works.

It actually creates an inscription without a file along with the etch, so no, it doesn't work

@ensfn
Copy link

ensfn commented Apr 18, 2024

you can do:

inscriptions:
-

It's a bit janky for now but works.

@raphjaph It doesn't work, still creates inscription with outrageous fees (at least for me for some reason). Can you provide guidance on how can I remove validations for that part of the code so I can do it at my own risk?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

7 participants