Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from partial inscription using recovery key #904

Open
casey opened this issue Dec 7, 2022 · 6 comments
Open

Recover from partial inscription using recovery key #904

casey opened this issue Dec 7, 2022 · 6 comments

Comments

@casey
Copy link
Collaborator

casey commented Dec 7, 2022

If the reveal transaction is not or cannot be mined, we should allow recovering inputs to the reveal transaction using the saved recovery key.

@casey casey added this to the Mainnet Inscriptions milestone Dec 7, 2022
@casey casey modified the milestones: Mainnet Inscriptions, Later Dec 14, 2022
@casey casey removed this from the Later milestone Dec 23, 2022
@hashbender
Copy link
Contributor

Would offer a bounty on this one 👍

@dannydeezy
Copy link

are we screwed if we tried inscribing with --no-backup here and it got stuck before making the reveal? @raphjaph @casey

@dannydeezy
Copy link

the acidelectro satoshi card might be stuck in a commit tx forever 😂😂

@raphjaph
Copy link
Collaborator

If you did with --no-backup you literally do not have the key to recover it, so yea you're screwed. Otherwise Bitcoin Core seems to recognize the unspent commit output and you can use it normally after it has been mined

@dannydeezy
Copy link

If you did with --no-backup you literally do not have the key to recover it, so yea you're screwed. Otherwise Bitcoin Core seems to recognize the unspent commit output and you can use it normally after it has been mined

is there a reason for using a random key pair here instead of deriving a key from the wallet's seed?

@raphjaph
Copy link
Collaborator

raphjaph commented Oct 2, 2023

That's a good point. I always thought we take a key from the wallet but just checked and we generate a new one.

The reason we need to back it up (I think) is because it is a rawtr descriptor (a tap-tweaked script). Now if we take a key from the wallet would that be enough for Bitcoin Core to find this weird output without the accompanying descriptor?

If you want to do some testing around this and open a PR I'd be happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants