Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure benchmark overhead on both Linux and macOS and fix any bottlenecks if excessive #30

Closed
hassila opened this issue Oct 6, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@hassila
Copy link
Contributor

hassila commented Oct 6, 2022

Should validate what the overhead of the time not spent in the actual benchmark code is (capturing OS, malloc statistics, sampling) and see what the magnitude is - and optimise if needed - there are some cheap wins (especially on Linux, where we could cache some open files etc) that could be done if needed. Need to put in probes and measure overhead as first step (i.e. total wall clock runtime vs. measured wall clock runtime delta).

@hassila hassila added the good first issue Good for newcomers label Oct 6, 2022
@hassila
Copy link
Contributor Author

hassila commented Oct 11, 2022

Several things addressed and basic measurements added as an empty benchmark that can be run (then use time to calculate overhead for e.g. a 100ms run). Caching of open files on Linux should probably eventually be added, but let's open a new issue if measurements prove there's an issue (simple to test with the empty benchmarks).

@hassila hassila closed this as completed Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

No branches or pull requests

1 participant