Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark is not capturing malloc/free appropriately for linked test case #50

Closed
hassila opened this issue Feb 3, 2023 · 2 comments
Closed

Comments

@hassila
Copy link
Contributor

hassila commented Feb 3, 2023

As outlined in https://forums.swift.org/t/benchmark-package-initial-release/60535/40
and using the repo at https://github.com/corymosiman12/swift-benchmark-testing - we don't properly capture the mallocs/frees, need to investigate whether it's due to failing to properly interpose jemalloc for Foundation, or if we simply miss some relevant jemalloc statistics that should be included.

@hassila
Copy link
Contributor Author

hassila commented Feb 3, 2023

Added minimised version of the tests into https://github.com/ordo-one/package-benchmark-samples

@hassila
Copy link
Contributor Author

hassila commented Feb 3, 2023

Actually, it was just a malformed test, it was only doing a single loop per test run and thus gave misleading statistics.

Adjusted the test code at e.g. https://github.com/ordo-one/package-benchmark-samples/blob/main/Benchmarks/MemoryOne/MemoryOne.swift

slightly and get expected results.

@hassila hassila closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant