Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back mainboard/emulation/qemu-riscv #622

Merged
merged 9 commits into from Nov 4, 2022

Conversation

rminnich
Copy link
Member

@rminnich rminnich commented Nov 1, 2022

This builds, as it has been drastically stripped down.

The sunxi nezha target should indicate how to add back drivers and such.

Signed-off-by: Ronald G. Minnich rminnich@google.com

@rminnich rminnich requested a review from a team November 1, 2022 18:35
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #622 (1db9afa) into main (5c2cabb) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #622   +/-   ##
=====================================
  Coverage   2.58%   2.58%           
=====================================
  Files         18      18           
  Lines        581     581           
=====================================
  Hits          15      15           
  Misses       566     566           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwerthmann
Copy link
Contributor

Does this fix #568 ?

@rminnich
Copy link
Member Author

rminnich commented Nov 1, 2022

I'm still trying to figure out how to crate the bios image

@luojia65
Copy link
Member

luojia65 commented Nov 2, 2022

@rminnich We can modify xtask builder to build an image. We may either add a hard coded platform in that package, or add a generic platform configuration parser for it.

@rminnich rminnich force-pushed the emuation-riscv branch 2 times, most recently from 3b420b1 to 027dbcd Compare November 3, 2022 20:48
@rminnich
Copy link
Member Author

rminnich commented Nov 3, 2022

is there any reason NOT to bring layoutflash back to life? It worked pretty well for building ROM images from a dtb and did not require specialization in xtask

@rminnich rminnich force-pushed the emuation-riscv branch 5 times, most recently from 5ba1520 to d1332ae Compare November 4, 2022 19:44
rminnichcodeu and others added 9 commits November 4, 2022 12:59
This builds, as it has been drastically stripped down.

The sunxi nezha target should indicate how to add back drivers and
such.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
it is simple and we can use a standard crate now, instead of the old
oreboot one

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
we may never need it -- need to study how nezha image is built.

All is built now SAVE the final image

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
uart_16550 is pretty naive as regards status bits, having no timeouts.
ns16550a is simpler, and hence more reliable with bad uarts
(like the one in qemu, as it happens).

With this change the UART is usable.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
@orangecms
Copy link
Contributor

is there any reason NOT to bring layoutflash back to life? It worked pretty well for building ROM images from a dtb and did not require specialization in xtask

I am very much in favor of using layoutflash in xtask. We can make the image stitching very declarative through it.

@orangecms orangecms merged commit 4fba7a7 into oreboot:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants