We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import dezero dezero.__version__ # '0.0.11'
Some tests depend on Chainer (for example, https://github.com/oreilly-japan/deep-learning-from-scratch-3/blob/master/tests/test_conv2d.py#L6). After Chainer is installed via pip, all tests run successfully.
I guess it's better to add Chainer is one of the external dependencies to README.
The text was updated successfully, but these errors were encountered:
I think so. And this code depend on Chainer(
deep-learning-from-scratch-3/steps/step59.py
Lines 4 to 6 in 81cbe3f
Sorry, something went wrong.
I think so too.
proposal (setup.py)
setup.py
setup(name='dezero', ... extras_require={ 'develop': ['chainer'] }, ... )
And pip install -e .[develop]
pip install -e .[develop]
ref: https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies
Thanks for suggestions!
Now Chainer is only needed at the unittests. So Chainer is not included at setup.py, but added at travis CI setup. https://github.com/oreilly-japan/deep-learning-from-scratch-3/blob/master/.travis.yml#L7
([develop] option is a good idea !)
[develop]
No branches or pull requests
Version
Some tests depend on Chainer (for example, https://github.com/oreilly-japan/deep-learning-from-scratch-3/blob/master/tests/test_conv2d.py#L6).
After Chainer is installed via pip, all tests run successfully.
I guess it's better to add Chainer is one of the external dependencies to README.
The text was updated successfully, but these errors were encountered: