Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better to include Chainer as external dependencies #6

Closed
yoheikikuta opened this issue Nov 26, 2019 · 3 comments
Closed

Better to include Chainer as external dependencies #6

yoheikikuta opened this issue Nov 26, 2019 · 3 comments

Comments

@yoheikikuta
Copy link

Version

import dezero
dezero.__version__
# '0.0.11'

Some tests depend on Chainer (for example, https://github.com/oreilly-japan/deep-learning-from-scratch-3/blob/master/tests/test_conv2d.py#L6).
After Chainer is installed via pip, all tests run successfully.

I guess it's better to add Chainer is one of the external dependencies to README.

@wakame1367
Copy link

I think so. And this code depend on Chainer(

from chainer import Chain
from chainer.optimizers import SGD
import chainer.links as L
)

@ftnext
Copy link
Contributor

ftnext commented Jan 6, 2020

I think so too.

proposal (setup.py)

setup(name='dezero',
      ...
      extras_require={
            'develop': ['chainer']
      },
      ...
      )

And pip install -e .[develop]

ref: https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies

@koki0702
Copy link
Collaborator

Thanks for suggestions!

Now Chainer is only needed at the unittests.
So Chainer is not included at setup.py, but added at travis CI setup.
https://github.com/oreilly-japan/deep-learning-from-scratch-3/blob/master/.travis.yml#L7

([develop] option is a good idea !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants