New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcToSat conversion precision #19

Open

scarceinscriptions opened this issue Mar 6, 2023 · 0 comments

scarceinscriptions commented Mar 6, 2023

btcToSat(btc) function is unsafe due to javascript floating point imprecision.

> let price = 0.01000014;
> price === satToBtc(btcToSat(price));
false

it may cause problems in generating and validating psbt offers.

I suggest using a safe arbitrary-precision decimal library for btc-denominated values and arithmetic.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment