Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Hiding the setting modal window and re-displaying it will set all user settings to false, but our default is true. #527

Open
ni00 opened this issue May 31, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ni00
Copy link

ni00 commented May 31, 2023

Expected Behavior

re-displaying it set all user settings to default
image
image

Current Behavior

re-displaying it set all user settings to false

Steps to reproduce

  1. Set default user configuration as true
  2. Correctly display settings modal window upon first opening
  3. Hide modal window (by clicking close or outside the modal window)
  4. Open modal window again.

Proposed fix or additional info.

Delete the discardUnsavedToggles method or add an optional configuration item to enable or disable it.

Version

2.9.1

On which browser do you see the issue?

Chrome

@ni00 ni00 added the bug Something isn't working label May 31, 2023
@github-actions github-actions bot added the triage yet to be reviewed label May 31, 2023
@orestbida
Copy link
Owner

This is an intentional change introduced in the last release: #481

The toggle.enabled option actually doesn't enable the category itself (although the toggle is marked as enabled) as it's supposed to work only when mode: "opt-out".

I will release an update that actually ignores the toggle.enabled option, unless mode is set to "opt-out".

@orestbida orestbida removed bug Something isn't working triage yet to be reviewed labels Jun 3, 2023
@orestbida orestbida added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants