Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy window functions produce different results than numpy window functions #14

Closed
mchitre opened this issue Nov 12, 2018 · 2 comments
Closed

Comments

@mchitre
Copy link
Member

mchitre commented Nov 12, 2018

scipy.signal.get_window('hanning', 64) does not work as well as np.hanning(64); same for other windows; need any fix in arlpy?

@mchitre mchitre self-assigned this Nov 12, 2018
@saimahmed
Copy link

They don't work when used as a filter in frequency domain ?

window = signal.get_window('hanning', 64, fftbins=False) and window = np.hanning(64) ,

These both output a symmetric window for filter design.

@mchitre mchitre added the fixed label Nov 14, 2018
@mchitre
Copy link
Member Author

mchitre commented Nov 14, 2018

They produce slightly different windows without the fftbins=False flag. With that flag, they should be identical. Anyway, this has already been fixed in arlpy and so closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants