Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrivals_to_impulse_response incorrect time scale #55

Closed
Erhannis opened this issue Nov 4, 2020 · 3 comments
Closed

arrivals_to_impulse_response incorrect time scale #55

Erhannis opened this issue Nov 4, 2020 · 3 comments
Assignees
Labels

Comments

@Erhannis
Copy link

Erhannis commented Nov 4, 2020

As shown in In https://arlpy.readthedocs.io/en/latest/_static/bellhop.html , it seems like arrivals_to_impulse_response gives an incorrect time scale. According to the preceding table and graph, the final arrival is recorded at 0.721796 seconds, but the plot of arrivals_to_impulse_response shows the final arrival at ~0.055 seconds. Likewise, the output of arrivals_to_impulse_response (ir) only contains 5293 elements, but given a total time of 0.721796 seconds and a rate of 96000 Hz, I'd have instead expected ~69292 elements.

@Erhannis
Copy link
Author

Erhannis commented Nov 5, 2020

Oh, no wait; I was wrong - I didn't notice that the first graph X starts at around 0.665, making the whole thing ~0.055 seconds wide. arrivals_to_impulse_response just shifts everything over such that the first arrival starts at t = 0, I think; sorry.

@Erhannis Erhannis closed this as completed Nov 5, 2020
@mchitre mchitre self-assigned this Nov 5, 2020
@mchitre mchitre added the invalid label Nov 5, 2020
@mchitre
Copy link
Member

mchitre commented Nov 5, 2020

@Erhannis arrivals_to_impulse_response() takes a keyword argument abs_time, which defaults to False. If you pass True, it'll give you in absolute time, according to the expectations you outlined in your original message.

@Erhannis
Copy link
Author

Erhannis commented Nov 5, 2020

Oh, neat; thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants