Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fjagejs CI broken #234

Closed
mchitre opened this issue Nov 8, 2021 · 3 comments
Closed

fjagejs CI broken #234

mchitre opened this issue Nov 8, 2021 · 3 comments
Assignees
Labels

Comments

@mchitre
Copy link
Member

mchitre commented Nov 8, 2021

Error on Linux CI:

org.arl.fjage.test.fjagejsTest > fjageJSTest FAILED
    java.lang.AssertionError: nodejs fjage.js test passed?
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert$assertTrue.callStatic(Unknown Source)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallStatic(CallSiteArray.java:55)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:196)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:216)
        at org.arl.fjage.test.fjagejsTest.fjageJSTest(fjagejsTest.groovy:103)

I get similar error on OS X.

@notthetup
Copy link
Collaborator

Interesting. It works fine on my setup on OSX. So I'm guessing it's something with the nodejs environment. I have added verbose logging to the CI and it seems to not run the jasmine tests at all but it runs the puppeteer ones just fine.

@notthetup
Copy link
Collaborator

notthetup commented Nov 9, 2021

OK. Figured it out. When we added #231, we moved the dependency of "compiling" the nodejs version of fjage.js (fjage.cjs) from processResources task to jars task

But when we run gradle test we don't run jars so fjage.js isn't being compiled.

@notthetup
Copy link
Collaborator

Fixed in 570b767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants