Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community::ServiceQuotas::EC2 #71

Open
zaro0508 opened this issue Jan 25, 2021 · 2 comments
Open

Community::ServiceQuotas::EC2 #71

zaro0508 opened this issue Jan 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@zaro0508
Copy link
Contributor

provider to set the custom Service Quota limits for EC2 resources. e.g: to increase the maximum number of instances per AZ and region.

@eduardomourar eduardomourar added the enhancement New feature or request label Jan 26, 2021
@PatMyron
Copy link
Contributor

PatMyron commented Apr 8, 2021

Instead of re-implementing specific Service Quota types, worth considering a generic type:

Properties:
  ServiceCode:
  QuotaCode:
  DesiredValue:

@OlafConijn
Copy link
Member

the reason i initially went with a different approach was that

  1. QuotaCodes are hard to figure out
  2. not all QuotaCodes work
  3. validating against upper/lower bounds would have to be done at runtime (and those APIs are also not super easy).
    all more/less developer experience arguments. not having all service quotas covered is probably an even more difficult than all of the above combined so 👍

I figured generating the types of the ServiceQuota api could be a thing (good coverage / good DX). Judging from the fact that has not happened the above would be a great alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants