Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a settings configuration from discord #4

Closed
5 tasks done
s0lst1ce opened this issue May 1, 2019 · 13 comments
Closed
5 tasks done

Add a settings configuration from discord #4

s0lst1ce opened this issue May 1, 2019 · 13 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented May 1, 2019

Add a suite of functions which allow any admin to change the way the bot works. More specifically it would allow to change settings in settings.py

Checklist of all that's left to do:

@s0lst1ce s0lst1ce added the enhancement New feature or request label May 1, 2019
@s0lst1ce s0lst1ce self-assigned this May 1, 2019
@s0lst1ce s0lst1ce added this to the 1.0 milestone May 1, 2019
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 3, 2019

To make this more powerful functions such as poll should depend not on channels' name but rather on their unique IDs. Those IDs would be logged and could be changed at any time.

@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 3, 2019

The same accounts for roles.

This was referenced May 3, 2019
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented May 6, 2019

All global setting in settings.py should be editable from discord

@s0lst1ce
Copy link
Collaborator Author

Should the configuration interface include all of the informations from the README.md ? @adrienluitot

@s0lst1ce
Copy link
Collaborator Author

Removed Slapping configuration.

@s0lst1ce
Copy link
Collaborator Author

@adrienluitot Huge question that would change everything I've done so far concerning server specific configuration... sometimes dramatic changes are required (yes I'm looking at you rewrite).
Anyways do you think there should be a config file for each server ? As of now there is a config file for each feature but I just thought that this may get ugly with time. I'll let you time to think about it and I'll pursue with the current structure in mind... for now. It change is needed, the hardest part will already be done.

@s0lst1ce
Copy link
Collaborator Author

This would even allow us to easily use JSON which is much more commonly understood by programmers. And it would also allow extensions to reload only specific files instead of everything each time a single modification has been done for any server.

@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented Jun 2, 2019

We are now switching to this new configuration structure for its benefits are numerous and more important than the current one.

@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented Jun 2, 2019

Also JSON will now be used for the configuration files. It's a common format much used among programmers and it's easy to handle in python using the json built-in module.
The config files will be named like this: guild_id.json

@s0lst1ce s0lst1ce mentioned this issue Jun 2, 2019
4 tasks
@adrienluitot
Copy link
Collaborator

I don't really know, it depends on how you want to "use" your bot. If you want to host it for other servers (not yours) I think have different config is needed. But in any case I think it could be cool if you have multiple server, for example if you have a french and an english server the "poll" channel will not have the same name.

@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented Jun 2, 2019

There will indeed be one host (me) who will run it for several servers. I'm not sure I understand what you mean by "poll" though ? Server owners are already able to mark any channel as a poll one. Thus the language doesn't matter, only IDs do.

@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented Jun 7, 2019

@adrienluitot all that's left is the Todo which I haven't looked at yet. We're almost there !

@s0lst1ce
Copy link
Collaborator Author

Finally completed with 5d59919
There will be improvements for v2 but this will be another issue's story. The same goes if new issues occur because of this.

@s0lst1ce s0lst1ce unpinned this issue Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants