Should git put git-htmldocs in /usr/share/doc/git-doc or /usr/share/doc/git-htmldocs?

[benknoble]

Output of brew config

HOMEBREW_VERSION: 4.2.12-44-ga7d7748
ORIGIN: https://github.com/Homebrew/brew
HEAD: a7d77485f103c5bec51681887ddfc41eb77789e8
Last commit: 12 days ago
Core tap JSON: 14 Mar 12:27 UTC
Core cask tap HEAD: 39c55075cadd9372d8c96b0a68a1979935a9f8fd
Core cask tap last commit: 12 days ago
Core cask tap JSON: 14 Mar 12:27 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.ViVvOe3X71/org.xquartz:0
HOMEBREW_EDITOR: /usr/local/bin/vim
HOMEBREW_MAKE_JOBS: 16
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.1.4 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/bin/ruby
CPU: 16-core 64-bit kabylake
Clang: 15.0.0 build 1500
Git: 2.44.0 => /usr/local/bin/git
Curl: 8.4.0 => /usr/bin/curl
macOS: 14.3-x86_64
CLT: 15.1.0.0.1.1700200546
Xcode: N/A

Output of brew doctor

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed casks are deprecated or disabled.
You should find replacements for the following casks:
  zsa-wally

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  python-jinja
  python-click
  python-pbr
  python-attrs
  python-sympy
  python-mpmath
  universal-ctags
  python-markupsafe

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  cowsay
  mono
  openssl@1.1
  python@3.8
  vault

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  ocaml
  parallel
  pygments
  pycparser
  cffi
  python-charset-normalizer

Warning: Homebrew's "sbin" was not found in your PATH but you have installed
formulae that put executables in /usr/local/sbin.
Consider setting your PATH for example like so:
  echo 'export PATH="/usr/local/sbin:$PATH"' >> ~/.zshrc

Description of issue

Git ships with the HTML docs available locally (they are also available at git-scm.com); AFAICT, they are installed as a resource.

They are currently installed to a path git-doc within /usr/share/doc (and within the Cellar, though that's tangential). All of Git's manual pages, however, reference git-htmldocs. For example, here's the bottom of man git:

NOTES
        1. Git User’s Manual
           git-htmldocs/user-manual.html

        2. Trace2 documentation
           git-htmldocs/technical/api-trace2.html

        3. Git concepts chapter of the user-manual
           git-htmldocs/user-manual.html#git-concepts

        4. howto
           git-htmldocs/howto-index.html

        5. Git API documentation
           git-htmldocs/technical/api-index.html

Now, the intra-docs links work, but I believe that's because they use relative URLs. So they should be able to be relocated to the expected git-htmldocs without issue.

---

Should the Git HTML documentation be placed at the expected path? They were added at git-doc to make git help -w work. While it does work, it can't open technical documentation or RelNotes anyway; in those cases, I still have to open /usr/local/doc/git-doc/…, after I remember that it's git-doc and not git-html-docs.

[benknoble]

PS the path to use is available via git --html-path.