Vercel
Next and Turborepo have conflicting paradigms for monorepos #2845
Replies: 5 comments 18 replies
-
Glad that you've noticed the work we've been doing here. Can you elaborate on why you feel this way? |
Beta Was this translation helpful? Give feedback.
-
|
Sure, I'd be happy to elaborate. Basically, I think that packages should be hermetic. I think this is a pretty common practice for monorepo tooling (especially bazel). I think that if Turborepo wants to properly support Vercel projects in monorepos, then all scripts related to a package should assume that the scripts are being run from inside the package folder. For instance, if I have a Vercel application located in apps/client, I think that the build, lint, test, etc. scripts should all be assumed to be running from apps/client as well. This is how everything is assumed to be working in Turboorepo already. I think that this is the correct paradigm to think about how package scripts should be ran, and the Vercel CLI is in conflict with that paradigm. For what it's worth, this workflow that I'm describing is 99% functioning for me right now (setting |
Beta Was this translation helpful? Give feedback.
-
|
What you're describing is completely correct, and indeed the current linking paradigm of Vercel CLI is at odds with that. You didn't mention anything specifically about
Be aware that setting the Root Directory project setting to the subpath within the repo where the app lives is the correct thing to do. For Please give the new linking paradigm a try (using latest Vercel CLI version) and let me know what you think. If you still feel it's moving in the wrong direction, please be specific. |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't seem to work for me |
Beta Was this translation helpful? Give feedback.
-
|
Is there a reason you've overridden the "Install Command" to be skipped? Seems like your |
Beta Was this translation helpful? Give feedback.
-
|
Ya you shouldn't need to override the "Install Command" for the prebuilt case. When doing The |
Beta Was this translation helpful? Give feedback.
-
|
For the prebuilt case, why wouldn't I override it? Otherwise, if i run |
Beta Was this translation helpful? Give feedback.
-
Can't debug if even that doesn't work. FWIW, I don't get this error when I don't use repo linking. |
Beta Was this translation helpful? Give feedback.
-
|
Skipping the install command sounds fine for your case, just be sure that you're installing the dependencies separately before invoking |
Beta Was this translation helpful? Give feedback.
-
Yeah, as you can see, the root directory for the app is getting duplicated |
Beta Was this translation helpful? Give feedback.
-
|
I found the problem: It fails because it can't find the application in this path. If i manually modify the This then gets back to the first point which is that it doesn't actually allow you to run build commands from the app directory. It seems to only work if you run from the repo root. |
Beta Was this translation helpful? Give feedback.
-
|
Also, I would have expected that I shouldn't need to select my project when running |
Beta Was this translation helpful? Give feedback.
-
|
Modifying that I think I'm narrowing down your issue though. Can you try this: set the |
Beta Was this translation helpful? Give feedback.
-
It still makes me select a project when i do this even without modifying the project.json. But If I modify the project.json to set However, I feel like I want the package.json script to be |
Beta Was this translation helpful? Give feedback.
-
|
Did Btw, I feel like we could diagnose this better over a call. If you got a few mins, feel free to DM me on Twitter and we can set up a zoom link. |
Beta Was this translation helpful? Give feedback.
-
|
This issue is resolved for me after talking with @TooTallNate Fix for me was the following:
|
Beta Was this translation helpful? Give feedback.
-
|
I was trying this approach before. But when I do
I believe this is because it tries to run the build script from |
Beta Was this translation helpful? Give feedback.
-
|
Hey @TooTallNate - this has been working beautifully since I found this post in June but v31 of the vercel CLI seems to have introduced a bug or breaking change which I am not sure what the expectation is. It doesn't seem to be respecting the My github actions line: run: npm install --global vercel@latest && vercel link --repo --yes --token $VERCEL_TOKENand the output is: Vercel CLI 31.0.3
WARN! The `--repo` flag is in alpha, please report issues
Loading scopes…
Fetching Projects for https://github.com/... under davetayls…
> Found 3 Projects linked to https://github.com/... under davetayls
? Which Projects should be linked to? (Press <space> to select, <a> to toggle al
l, <i> to invert selection)
› ▪︎ davetayls/a
▪︎ davetayls/b
▪︎ davetayls/c
Error: Process completed with exit code 130. |
Beta Was this translation helpful? Give feedback.
-
|
it works for me as of v33.5.1 |
Beta Was this translation helpful? Give feedback.
-
Page to Investigate
vercel/vercel#8794 (comment)
Steps to Reproduce
I've outlined this problem in the comment linked above. I wanted to make a broader discussion in the Vercel community discussions as I feel like there's a conflict in how monorepo tooling ought to work and how the Vercel CLI wants things to work by defining everything in the root of a repository.
I've been following the progress with the Vercel CLI monorepo settings (
--repo), but this seems to be just going further in the wrong direction (in my opinion).Would appreciate input from @leerob here.
Beta Was this translation helpful? Give feedback.
All reactions