Add Logger notifier #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| describe '#logger' do | ||
| it 'reads the logger' do | ||
| logger = Logger.new(STDOUT) |
There was a problem hiding this comment.
I would prefer testing with StringIO instead of standard out and error. You can see some example usage of StringIO in the IO notifier spec.
|
Thanks for opening this pull request! This looks like a good addition to Stoplight. If we do merge this, we will also need to update the notifiers section of the readme to include this notifier. |
|
Hi thanks for feedback! I've just updated REAMDE and specs. |
| @@ -321,7 +334,7 @@ Stoplight: | |||
| # config/initializers/stoplight.rb | |||
| require 'stoplight' | |||
| Stoplight::Light.default_data_store = Stoplight::DataStore::Redis.new(...) | |||
| Stoplight::Light.default_notifiers += [Stoplight::Notifier::HipChat.new(...)] | |||
| Stoplight::Light.default_notifiers += [Stoplight::Notifier::Logger.new(Rails.logger)] | |||
|
Once you fix the |
|
Released in v1.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.